Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps update 10 2024 #5670

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Conversation

mdabek-nvidia
Copy link
Collaborator

Category:

Other

Description:

Dependencies update:

  • Google Benchmark to v1.9.0
  • DLPack to v1.0
  • FFTS to of the tree 09/2024
  • GoogleTest to v1.15.2
  • pybind11 to v2.13.6
  • RapidJSON to top of the tree 09/2024

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-4068

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
+------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------------------------------------------------+
| `FFTS <https://github.com/JanuszL/ffts>`_ | `Custom fork top-of-tree (Jan 23, 2020) <https://github.com/JanuszL/ffts/tree/c9a9f61a60505751cac385ed062ce2720bdf07d4>`_ | `BSD 3-Clause License <https://github.com/JanuszL/ffts/blob/master/COPYRIGHT>`_ |
| `FFTS <https://github.com/JanuszL/ffts>`_ | `Custom fork top-of-tree (Sep 6, 2024) <https://github.com/JanuszL/ffts/tree/95489ebcd6fc136c6a76f50f57d43e6072e2bd38>`_ | `BSD 3-Clause License <https://github.com/JanuszL/ffts/blob/master/COPYRIGHT>`_ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I forgot that I updated my fork to support more recent gcc compiler available ion manylinux_2_28 image - due to pending #5608.

@JanuszL JanuszL self-assigned this Oct 9, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19172182]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19172182]: BUILD FAILED

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19183753]: BUILD STARTED

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19186116]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19183753]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19186116]: BUILD FAILED

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19191481]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19191481]: BUILD FAILED

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19208816]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19209138]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19209138]: BUILD FAILED

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19213645]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19213645]: BUILD FAILED

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19217037]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19217037]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19249047]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19252883]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19252883]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19252883]: BUILD PASSED

@mdabek-nvidia mdabek-nvidia marked this pull request as ready for review October 14, 2024 12:02
Comment on lines 124 to 139
"${DEPS_PATH}/lib/libaws-crt-cpp.so"
"${DEPS_PATH}/lib/libaws-c-mqtt.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-event-stream.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-common.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-common.so.1"
"${DEPS_PATH}/lib/libaws-c-sdkutils.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-io.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-cal.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-compression.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-http.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-auth.so.1.0.0"
"${DEPS_PATH}/lib/libaws-checksums.so.1.0.0"
"${DEPS_PATH}/lib/libaws-cpp-sdk-s3.so"
"${DEPS_PATH}/lib/libaws-c-s3.so.1.0.0"
"${DEPS_PATH}/lib/libaws-c-s3.so.0unstable"
"${DEPS_PATH}/lib/libs2n.so.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the structure of the aws build somehow changed and those were not built before or we should have bundled them before but were lucky?

@stiepan stiepan self-assigned this Oct 14, 2024
@stiepan
Copy link
Member

stiepan commented Oct 14, 2024

For conda, we have separate recipes for a few of the deps (e.g. ffmpeg) and updating one of those in DALI_deps usually requires upding the recipe too. There's jpeg-turbo among the custom recipes, but, looking at the build log, I am not sure it's actually used.

@JanuszL
Copy link
Contributor

JanuszL commented Oct 14, 2024

There's jpeg-turbo among the custom recipes
It is not used there anymore.

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@mdabek-nvidia
Copy link
Collaborator Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19372617]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19372617]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [19372617]: BUILD PASSED

@mdabek-nvidia mdabek-nvidia merged commit 0d55aa0 into NVIDIA:main Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants