Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make exec_dynamic non-experimental (alternative formatting) #5704

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Nov 7, 2024

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)
Other Documentation

Description:

  • change the parameter name
  • add documentation in Pipeline
  • update documentation of fn.shapes and fn.peek_image_shape
  • update examples to use .shape() instead of fn.shapes or fn.peek_image_shape
  • deprecate experimental_exec_dynamic
  • remove mentions of impossibility of returning to CPU

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-4087, DALI-4088

mzient and others added 6 commits November 7, 2024 15:09
- change the parameter name
- add documentation
- update examples
- deprecate `experimental_exec_dynamic`

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20181715]: BUILD STARTED

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20181715]: BUILD FAILED

@mzient mzient force-pushed the exec_dynamic_non_experimental_ugly_docs branch from 1489901 to 6cd0b45 Compare November 8, 2024 07:35
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20198907]: BUILD STARTED

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient force-pushed the exec_dynamic_non_experimental_ugly_docs branch from 6cd0b45 to 620c471 Compare November 8, 2024 07:40
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20199010]: BUILD STARTED

@mzient mzient assigned banasraf and szalpal and unassigned klecki and stiepan Nov 8, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [20199010]: BUILD PASSED

@mzient mzient merged commit 2c7c512 into NVIDIA:main Nov 8, 2024
6 checks passed
@mzient mzient mentioned this pull request Nov 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants