-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make exec_dynamic
non-experimental (alternative formatting)
#5704
Merged
mzient
merged 9 commits into
NVIDIA:main
from
mzient:exec_dynamic_non_experimental_ugly_docs
Nov 8, 2024
Merged
Make exec_dynamic
non-experimental (alternative formatting)
#5704
mzient
merged 9 commits into
NVIDIA:main
from
mzient:exec_dynamic_non_experimental_ugly_docs
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change the parameter name - add documentation - update examples - deprecate `experimental_exec_dynamic` Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
CI MESSAGE: [20181715]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
CI MESSAGE: [20181715]: BUILD FAILED |
mzient
force-pushed
the
exec_dynamic_non_experimental_ugly_docs
branch
from
November 8, 2024 07:35
1489901
to
6cd0b45
Compare
CI MESSAGE: [20198907]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
mzient
force-pushed
the
exec_dynamic_non_experimental_ugly_docs
branch
from
November 8, 2024 07:40
6cd0b45
to
620c471
Compare
CI MESSAGE: [20199010]: BUILD STARTED |
banasraf
approved these changes
Nov 8, 2024
CI MESSAGE: [20199010]: BUILD PASSED |
jantonguirao
approved these changes
Nov 8, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Other Documentation
Description:
Pipeline
fn.shapes
andfn.peek_image_shape
.shape()
instead offn.shapes
orfn.peek_image_shape
experimental_exec_dynamic
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4087, DALI-4088