-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all parameter references from double backticks to single #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
commented
Nov 19, 2024
!build |
CI MESSAGE: [20578019]: BUILD STARTED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
!build |
CI MESSAGE: [20578956]: BUILD STARTED |
CI MESSAGE: [20578956]: BUILD FAILED |
mdabek-nvidia
approved these changes
Nov 20, 2024
szkarpinski
approved these changes
Nov 21, 2024
!build |
CI MESSAGE: [20777008]: BUILD STARTED |
CI MESSAGE: [20777008]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Other
Description:
Semi-automatically search for all parameters wrapped in double backticks and replace them with single backticks so that the sphinx automation can recognize them and inject the
:paramref:
directive allowing for proper linking to parameters via their references.Additional information:
Affected modules and functionalities:
Docstring, some deprecation mechanism.
There might be too much changes applied (some strings were used in the errors/warnings), so review of the changes and running the tests is necessary to revert some of the changes.
I see few glitches, will fix them tomorrow.
Key points relevant for the review:
Please click on the links and check if they work :)
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A