Return TensorLayout by const-reference. #5730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
To facilitate representation of the TensorLayout in C API as a simple
const char *
, the layout query functions in TensorList should return a pointer to a persistent storage. In this case, we can simply return thec_str()
of the TensorLayout stored inside a Tensor(List).Additional information:
Affected modules and functionalities:
All and nothing :) This is a small change and should not affect client code, but cases a massive rebuild.
Key points relevant for the review:
Tests:
All tests that use layouts - which is pretty much everything in Python and lots of GTests.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A