Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a typical data loading pipeline path for the EfficeintNet #5761

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Dec 20, 2024

  • adds an option to run the EfficeintNet network with a typical
    data loading pipeline without very advanced optimization that
    most users won't implement

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • adds an option to run the EfficeintNet network with a typical
    data loading pipeline without very advanced optimization that
    most users won't implement

Additional information:

Affected modules and functionalities:

  • EfficientNet example

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • TL3_EfficientNet_benchmark
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- adds an option to run the EfficeintNet network with a typical
  data loading pipeline without very advanced optimization that
  most users won't implement

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Dec 20, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21708341]: BUILD STARTED

input = next_input
target = next_target
def prefetched_loader(loader, num_classes, one_hot, typical_loader ):
if typical_loader:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider building a TypicalPytorchLoader as a separate class that just omits prefetching and fast_collate instead of introducing if-branches everywhere. It can even land in a separate file with docstring explaining that it's created according to the doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Dec 20, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21709902]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21709902]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21781968]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21785497]: BUILD STARTED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21790097]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21785497]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [21790097]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants