Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect protocol for socket.io uri to add https support #1333

Closed
wants to merge 10 commits into from

Conversation

stevefox
Copy link

@stevefox stevefox commented Dec 6, 2016

This adds support for socket.io requests when SSL is enabled.

@stevefox stevefox mentioned this pull request Dec 6, 2016
@lukeyeager
Copy link
Member

Hi @stevefox. This seems like a reasonable change. But it's too late to pull this into the digits-5.0 release branch. I'll edit your PR to direct the change towards the master branch ...

@lukeyeager lukeyeager changed the base branch from digits-5.0 to master December 7, 2016 17:34
@lukeyeager
Copy link
Member

Oh rats, that wasn't very smooth. If you're comfortable enough with git, can you update this branch properly? Otherwise just feel free to close this and open a new one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants