Skip to content

Commit

Permalink
Update cublasMMWrapper.cc
Browse files Browse the repository at this point in the history 
Fix the CUBLAS_VERSION checking of cublasMMWrapper
  • Loading branch information
@byshiue
byshiue authored Apr 18, 2023
1 parent 169b8df commit a6ef7af
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/fastertransformer/utils/cublasMMWrapper.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ std::pair<bool, cublasLtMatmulAlgo_t> cublasMMWrapper::findBestAlgo(cublasLtHand
cublasLtMatrixLayout_t Ddesc,
cudaStream_t stream)
{
#if (CUBLAS_VERSION) <= 11402
#if (CUBLAS_VERSION) < 11601
FT_CHECK_WITH_INFO(false, "CUBLAS version too low.");
return {false, cublasLtMatmulAlgo_t{}};
#else
Expand Down

2 comments on commit a6ef7af

@xshaun
Copy link

@xshaun xshaun commented on a6ef7af Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also change the line-987 #if (CUBLAS_VERSION) <= 11402 to #if (CUBLAS_VERSION) <= 11601 since the compiling error occurs at line-1019 per_column_scaling ? CUBLASLT_POINTER_MODE_ALPHA_DEVICE_VECTOR_BETA_HOST : CUBLASLT_POINTER_MODE_DEVICE;. Thanks

@byshiue
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Fixed.

Please sign in to comment.