[Improvement] accelerate T5 model conversion and fix bloom model on multi-process #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
changed the title
rohithkrn
approved these changes
Feb 11, 2023
byshiue
reviewed
Feb 13, 2023
| def convert_and_save_parameter(config: PretrainedConfig, | ||
| name: str, | ||
| param: torch.nn.Parameter, | ||
| def convert_and_save_parameter(param_name: str, |
There was a problem hiding this comment.
You change the API, but don't update the line 333.
There was a problem hiding this comment.
I changed that in the following commit. But maybe we can just remove if else statement and use star_async. 1 process can still work under this condition.
There was a problem hiding this comment.
I would assume everyone even the laptop now should have 4 cores, so 1 core condition not common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
Flan-T5-xxl (49GB) conversion time reduced from 11 min to 4 min on a 64 core CPU with 4 concurrent process
If you do:
With Bloom conversion script. You will reproduce the bus error. This PR include a fix to address that