New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scale input bug inside AddBiasResidualLayerNorm kernel #466

Merged

byshiue merged 1 commit into NVIDIA:main from zobinHuang:main

Feb 28, 2023

Contributor

zobinHuang commented Feb 22, 2023 •

edited

Loading

Fixed two bugs inside generalAddBiasResidualLayerNormOpt kernel:

[1] Line 80~86: The origin logic of whether to scale input seems to be reversed;

[2] Line 87: add val with in_val , instead of input[index]


          fix: scale input bug inside AddBiasResidualLayerNorm kernel

5dd3ca8

byshiue merged commit 8bf96eb into NVIDIA:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet