Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] GptJ & GptNeoX batch inference error #742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix] GptJ & GptNeoX batch inference error #742

wants to merge 1 commit into from

Conversation

YZP17121579
Copy link

GptJ & GptNeoX may generate random outputs when using batch inference mode and no prefix prompt.
The problem is caused by the nullptr check
in

FasterTransformer/src/fastertransformer/kernels/gpt_kernels.cu

Line 1064 in f8e42aa

if (tiled_prefix_prompt_lengths != nullptr) {

@BasicCoder
Copy link

BasicCoder commented Aug 12, 2023 •
edited
Loading

I think this is a duplicate solution of #716 which is more elegant and efficient.

@RobotGF RobotGF mentioned this pull request Sep 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YZP17121579 @BasicCoder