Propagate build failures (#363)

Always run the `publish-build` step, regardless of whether the rosetta pax/t5x build was attempted. This ensures that badges correctly reflect build failures due to dependent builds failing.
NVIDIA · Nov 8, 2023 · f7a4f44 · f7a4f44
1 parent a391095
commit f7a4f44
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/nightly-rosetta-pax-build.yaml b/.github/workflows/nightly-rosetta-pax-build.yaml
@@ -67,7 +67,7 @@ jobs:
   publish-build:
     needs: [metadata, build]
     uses: ./.github/workflows/_publish_badge.yaml
-    if: ( success() || failure() ) && (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') || github.event_name == 'workflow_dispatch'
+    if: ( always() )
     secrets: inherit
     with:
       ENDPOINT_FILENAME: 'rosetta-pax-build-status.json'

diff --git a/.github/workflows/nightly-rosetta-t5x-build-test.yaml b/.github/workflows/nightly-rosetta-t5x-build-test.yaml
@@ -69,7 +69,7 @@ jobs:
   publish-build:
     needs: [metadata, build]
     uses: ./.github/workflows/_publish_badge.yaml
-    if: ( success() || failure() ) && (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') || github.event_name == 'workflow_dispatch'
+    if: ( always() )
     secrets: inherit
     with:
       ENDPOINT_FILENAME: 'rosetta-t5x-build-status.json'