Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JetStream to MaxText container #1058

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

DwarKapex
Copy link
Contributor

@DwarKapex DwarKapex commented Sep 23, 2024

This is the first step to bring JetStream for MaxText.
The next step will be adding perf tests for couple JetStream + MaxText

@DwarKapex DwarKapex requested review from kocchop, nouiz and yhtang and removed request for kocchop and nouiz September 24, 2024 20:47
@DwarKapex DwarKapex self-assigned this Sep 26, 2024
Copy link
Contributor

@kocchop kocchop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase it on top of #1070

@kocchop
Copy link
Contributor

kocchop commented Oct 3, 2024

In addition to the pip install -r requirements.txt we also need to add pip install . from the JetStream repo. The google-jetstream that is installed as part of maxtext requirements is not the latest. The above step would uninstall it and install the most recent compiled one from the repo.

@yhtang
Copy link
Collaborator

yhtang commented Oct 10, 2024

In addition to the pip install -r requirements.txt we also need to add pip install . from the JetStream repo. The google-jetstream that is installed as part of maxtext requirements is not the latest. The above step would uninstall it and install the most recent compiled one from the repo.

Do you mean to add something like

echo "-e ${SRC_PATH_JETSTREAM}" >> /opt/pip-tools.d/requirements-jetstream.in

?

Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@DwarKapex DwarKapex requested review from kocchop and yhtang January 9, 2025 22:52
@DwarKapex DwarKapex requested review from olupton and nouiz January 10, 2025 17:01
.github/container/Dockerfile.maxtext Outdated Show resolved Hide resolved
.github/workflows/_ci.yaml Outdated Show resolved Hide resolved
bash <<"EOF" |& tee test-jetstream.log
cd /opt/jetstream
pip install -r requirements.txt
export CUDA_VISIBLE_DEVICES=0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test multi-GPU functionality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find JetStream unit-test examples on GitHub for multi-GPU. Even more: afaik, it does not support GPUs so far. But it will start GPU support in the nearest future.

@DwarKapex DwarKapex requested review from nouiz and olupton January 16, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants