Work around upstream hermetic Python changes #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
olupton
commented
May 22, 2024
olupton
commented
- Always use editable installations of jax and jaxlib, which avoids having to deal with wheel filenames that have dates in them. Using an editable installation requires that we disable hashes.
- Do not tackle the problem that this leaves the JAX source repo in a dirty state. People will have to be careful not to merge the modified requirements files.
olupton
force-pushed
the
olupton/hermetic-python-fix
branch
from
4413b2b to
b08fc25
Compare
gpupuck
reviewed
May 22, 2024
- Always use editable installations of jax and jaxlib, which avoids having to deal with wheel filenames that have dates in them. Using an editable installation requires that we disable hashes. - Do not tackle the problem that this leaves the JAX source repo in a dirty state. People will have to be careful not to merge the modified requirements files.
olupton
force-pushed
the
olupton/hermetic-python-fix
branch
from
5570f05 to
a6c3a0e
Compare
gspschmid
approved these changes
May 23, 2024
gpupuck
reviewed
May 23, 2024
| pushd "${SRC_PATH_JAX}" | ||
| echo "${line}" >> build/requirements.in | ||
| PYTHON_VERSION=$(python -c 'import sys; print("{}.{}".format(*sys.version_info[:2]))') | ||
| bazel run //build:requirements_dev.update --repo_env=HERMETIC_PYTHON_VERSION="${PYTHON_VERSION}" |
There was a problem hiding this comment.
One thing I wasn't so sure is that, is this setting HERMETIC_PYTHON_VERSION really necessary? I thought by default it's gonna use the system's python version. Could you try that? Other than that, everything else looks good!
There was a problem hiding this comment.
https://jax.readthedocs.io/en/latest/developer.html#specifying-python-version says it's only set automatically via build.py, which doesn't have a way of triggering requirements_dev.update. The _dev version is needed to avoid putting hashes in the requirements file, which blocks using an editable installation.
gpupuck
approved these changes
May 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.