Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix communicator_test.py #2019

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix communicator_test.py #2019

merged 1 commit into from
Sep 21, 2023

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Sep 20, 2023 •
edited
Loading

Description

This test had racing issue.
Multiple threads could try to modify a_ready/b_ready.

Changed to disable it for now.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Sep 20, 2023
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

1 similar comment
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 35da789 into NVIDIA:main Sep 21, 2023
15 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_fuel_f3_comm_test branch September 21, 2023 20:58
holgerroth pushed a commit to holgerroth/NVFlare that referenced this pull request Dec 4, 2023
@YuanTingHsieh
Fix communicator_test.py (NVIDIA#2019)
ad7cf22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
cicd continuous integration/continuous development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @nvidianz