Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address VDR feedback #2297

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Address VDR feedback #2297

merged 3 commits into from
Jan 23, 2024

Conversation

SYangster
Copy link
Collaborator

  • added fl introduction
  • misc updates based on vdr interim report

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good write up, just few minor comments where you need to be aware the aggregator node may not be FL server node

@chesterxgchen
Copy link
Collaborator

@SYangster you need to create the same PR for 2.4 branch

@SYangster SYangster mentioned this pull request Jan 22, 2024
Merged
6 tasks
@SYangster SYangster force-pushed the vdr_improvements branch 2 times, most recently from 35ffa42 to f1d34e3 Compare January 22, 2024 23:00
YuanTingHsieh
YuanTingHsieh previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@YuanTingHsieh
Copy link
Collaborator

needs to merge #2305 first

YuanTingHsieh
YuanTingHsieh approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster SYangster merged commit 657d638 into NVIDIA:main Jan 23, 2024
15 checks passed
@SYangster SYangster deleted the vdr_improvements branch January 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @chesterxgchen @YuanTingHsieh