Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Fix ParamsConverter signature #2310

Merged
merged 2 commits into from
Jan 24, 2024
Merged

[2.4] Fix ParamsConverter signature #2310

merged 2 commits into from
Jan 24, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Jan 23, 2024 •
edited
Loading

Description

PR #2260 add required functionalities but it breaks the "Filter" base class signature.
This PR removes the "Filter" base class inheritance

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh marked this pull request as draft January 23, 2024 23:13
SYangster
SYangster reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep as Filter and move task_name argument to be passed through fl_ctx instead, or we rather remove Filter base class?

@YuanTingHsieh YuanTingHsieh force-pushed the fix_param_converter_24 branch from e543153 to 2c9da1e Compare January 24, 2024 01:12
@YuanTingHsieh YuanTingHsieh marked this pull request as ready for review January 24, 2024 01:15
@YuanTingHsieh YuanTingHsieh force-pushed the fix_param_converter_24 branch from 2c9da1e to 95440d9 Compare January 24, 2024 01:16
@YuanTingHsieh YuanTingHsieh mentioned this pull request Jan 24, 2024
Merged
6 tasks
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 77039b2 into NVIDIA:2.4 Jan 24, 2024
15 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_param_converter_24 branch January 24, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster left review comments

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @chesterxgchen @SYangster