Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address final VDR feedbacks #2332

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Address final VDR feedbacks #2332

merged 4 commits into from
Feb 2, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

  • Change Title "Execution API Type" to "From Local to Federated" as suggested
  • Fix typos
  • Add software / minimum hardware requirements
  • Add docstrings

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

chesterxgchen
chesterxgchen previously approved these changes Feb 1, 2024
View reviewed changes
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh enabled auto-merge (squash) February 1, 2024 23:51
@YuanTingHsieh
Copy link
Collaborator Author

/build

1 similar comment
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit da9562a into NVIDIA:main Feb 2, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_vdr_final_issues branch February 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @chesterxgchen