Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address VDR report #2335

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Address VDR report #2335

merged 6 commits into from
Feb 2, 2024

Conversation

SYangster
Copy link
Collaborator

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest some changes.

My grammar might be OFF.
And please double check the links or ref I provided

docs/getting_started.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/programming_guide/experiment_tracking.rst Outdated Show resolved Hide resolved
docs/programming_guide/experiment_tracking.rst Outdated Show resolved Hide resolved
examples/hello-world/step-by-step/cifar10/sag_executor/sag_executor.ipynb Outdated Show resolved Hide resolved
job_templates/readme.md Show resolved Hide resolved
docs/user_guide/nvflare_cli/fl_simulator.rst Outdated Show resolved Hide resolved
YuanTingHsieh
YuanTingHsieh previously approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster enabled auto-merge (squash) February 2, 2024 17:29
@SYangster SYangster merged commit 8c10f56 into NVIDIA:main Feb 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @chesterxgchen @YuanTingHsieh