Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xgboost tree code #2383

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Update xgboost tree code #2383

merged 2 commits into from
Mar 6, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Move common method outside to a utils file

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 0c30363 into NVIDIA:main Mar 6, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the update_xgboost_tree_main branch March 6, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @SYangster