-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Job submission with binary protocol #2393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanchengnv
requested review from
nvidianz,
yhwen,
IsaacYangSLA and
YuanTingHsieh
March 7, 2024 20:39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, have questions regarding if we should handle the file being removed/closed by other people/process using the same machine.
YuanTingHsieh
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
The current job submission uses text protocol, which is very inefficient. It consumes large amount of memory space, especially when the job contains large data files (e.g. pre-trained model weights):
During this process, the job data gets converted from base64 to bytes to FOBS encoding, at least tripling the memory usage. When the job contains large data files and the user tries to submit multiple such jobs at the same time, the system can quickly run out of memory. Even if the server doesn't crash, the system becomes practically unusable - everything becomes extremely slow.
This PR tries to solve the problem by completely avoiding these unnecessary memory usage:
The same binary protocol is also used for downloading job from the server to admin client.
The binary exchange protocol has built-in checksum validation that ensures the data integrity during exchange.
Additional improvement:
Types of changes
./runtest.sh
.