Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated FOBS readme to add DatumManager, added agrpcs as secure scheme #2410

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Updated FOBS readme to add DatumManager, added agrpcs as secure scheme #2410

merged 2 commits into from
Mar 19, 2024

Conversation

nvidianz
Copy link
Collaborator

Merge following changes made to 2.4 to main branch,

Updated FOBS README to add DatumManager
Added agrpcs, ngrpcs as secure scheme

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but hope you add unit tests

@IsaacYangSLA
Copy link
Collaborator

/build

@IsaacYangSLA
Copy link
Collaborator

/build

@nvidianz nvidianz merged commit 7d26dcc into NVIDIA:main Mar 19, 2024
16 checks passed
@nvidianz nvidianz deleted the fobs-doc-agrpcs branch March 19, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvidianz @IsaacYangSLA @chesterxgchen @SYangster