Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to client api send method #2425

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add check to client api send method #2425

merged 1 commit into from
Mar 20, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

If the fl_model is not FLModel, raise TypeError

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh merged commit 6e4f444 into NVIDIA:main Mar 20, 2024
15 checks passed
@YuanTingHsieh YuanTingHsieh deleted the add_client_api_send_check branch March 20, 2024 17:34
@YuanTingHsieh YuanTingHsieh mentioned this pull request Mar 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @SYangster