Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.4] Clarify download_job workspace delay #2453

Merged
merged 2 commits into from
Apr 1, 2024
Merged

[2.4] Clarify download_job workspace delay #2453

merged 2 commits into from
Apr 1, 2024

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Mar 27, 2024 •
edited
Loading

Fixes https://jirasw.nvidia.com/browse/FLARE-1888
Add note about delay in workspace creation for larger jobs, which can cause download_job to be unsuccessful.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@SYangster SYangster changed the title Clarify download_job workspace delay [2.4] Clarify download_job workspace delay Mar 27, 2024
@SYangster SYangster requested a review from yanchengnv March 27, 2024 21:08
@SYangster SYangster mentioned this pull request Mar 27, 2024
Merged
6 tasks
yanchengnv
yanchengnv approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit a5af581 into NVIDIA:2.4 Apr 1, 2024
16 checks passed
@SYangster SYangster deleted the workspace_delay_doc branch April 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYangster @yanchengnv