Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Add warning when the same admin in project.yml has different role #2469

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

IsaacYangSLA
Copy link
Collaborator

Description

By design, provisioners can add clients or admins in project.yml and do provision to get additional client/admin startup kits. The certs and private keys of existing participants are kept the same so that there is no need to re-distribute those existing startup kits.

When the role of existing admin changes in project.yml, its cert/private key and thus the role in subject's unstructured_name, do not change. This causes confusion as provisioners may think a new set of cert/private key is generated.

This PR adds a warning during provisioning time so that provisioners know what to do to generate the new startup kits.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@IsaacYangSLA IsaacYangSLA requested a review from yhwen April 3, 2024 23:34
@IsaacYangSLA IsaacYangSLA requested a review from yhwen April 4, 2024 15:53
Copy link
Collaborator

@yhwen yhwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsaacYangSLA
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 5c51c80 into NVIDIA:2.4 Apr 4, 2024
16 checks passed
@IsaacYangSLA IsaacYangSLA deleted the admin_role_change branch July 31, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants