Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] F3 Streaming Code Rewrite #2956

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[2.5] F3 Streaming Code Rewrite #2956

merged 1 commit into from
Sep 25, 2024

Conversation

nvidianz
Copy link
Collaborator

Fixes FLARE-2241

  1. Refactored F3 streaming code so it's more object oriented, easier to debug.
  2. Fixed a few corner cases found during testing with a testing driver that injects duplicate packets.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvidianz nvidianz requested a review from yanchengnv September 23, 2024 21:10
yanchengnv
yanchengnv requested changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further improvements suggested. See my comments.

nvflare/fuel/f3/streaming/byte_receiver.py Outdated Show resolved Hide resolved
nvflare/fuel/f3/streaming/byte_receiver.py Outdated Show resolved Hide resolved
nvflare/fuel/f3/streaming/byte_streamer.py Outdated Show resolved Hide resolved
@nvidianz nvidianz changed the base branch from 2.5 to main September 25, 2024 19:39
@nvidianz nvidianz changed the base branch from main to 2.5 September 25, 2024 19:39
@nvidianz nvidianz force-pushed the flare-2241-f3-streaming-rewrite branch from ff4b3c8 to 5e65e3e Compare September 25, 2024 19:48
yanchengnv
yanchengnv approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvidianz
Copy link
Collaborator Author

/build

@nvidianz nvidianz merged commit 9db7ce0 into NVIDIA:2.5 Sep 25, 2024
16 checks passed
@nvidianz nvidianz deleted the flare-2241-f3-streaming-rewrite branch September 25, 2024 20:39
@YuanTingHsieh YuanTingHsieh mentioned this pull request Sep 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvidianz @YuanTingHsieh @yanchengnv