Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Fix simulator result path #2967

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Fix simulator result path

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the examples Label for all example related work label Sep 26, 2024
@YuanTingHsieh
Copy link
Collaborator Author

@ZiyueXu77 Do we need to correct the path for BRAT18 and prostate as well?

@ZiyueXu77
Copy link
Collaborator

@ZiyueXu77 Do we need to correct the path for BRAT18 and prostate as well?

For brats, I don't think so since we directly use the root folder "tensorboard --logdir='./workspace_brats'"
But for prostate, we may need to update the path in https://github.com/NVIDIA/NVFlare/blob/main/examples/advanced/prostate/result_stat/plot_tensorboard_events.py (although we used blob to search for the record)

@YuanTingHsieh
Copy link
Collaborator Author

/build

Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@YuanTingHsieh YuanTingHsieh merged commit db6c29c into NVIDIA:2.5 Sep 27, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_simulator_path_25 branch September 27, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Label for all example related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants