Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] update PSI to support python 3.11 #2973

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[2.5] update PSI to support python 3.11 #2973

merged 1 commit into from
Oct 1, 2024

Conversation

chesterxgchen
Copy link
Collaborator

Description

update openmind-psi==2.0.4 to support python 3.11

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen chesterxgchen changed the title [2.5] update PSI to to support python 3.11 [2.5] update PSI to support python 3.11 Oct 1, 2024
@chesterxgchen
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could see if we want to add it back to setup.cfg when 3.12 is supported

@chesterxgchen chesterxgchen merged commit ea97593 into NVIDIA:2.5 Oct 1, 2024
20 checks passed
@chesterxgchen chesterxgchen deleted the psi_2.5 branch October 1, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesterxgchen @YuanTingHsieh