Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Job api update #2991

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Cherry-pick #2975 #2980

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yanchengnv and others added 2 commits October 4, 2024 10:20
* support object reuse

* fix formatting

---------

Co-authored-by: Sean Yang <seany314@gmail.com>
Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <yuantingh@nvidia.com>
* support object reuse

* fix formatting

* allow multiple workflows in ccwf

* allow multiple workflows in ccwf

---------

Co-authored-by: Sean Yang <seany314@gmail.com>
Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <yuantingh@nvidia.com>
@YuanTingHsieh
Copy link
Collaborator Author

/build

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 7d28fb8 into NVIDIA:2.5 Oct 4, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the job_api_update_25 branch October 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants