Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Update pt params converter (#2989) #2997

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[2.5] Update pt params converter (#2989) #2997

merged 2 commits into from
Oct 7, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Cherry-pick #2989

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth @YuanTingHsieh
Update pt params converter (NVIDIA#2989)
bb6108b 
* update pt params converter

* use exclude_vars

* print warning

* add return value
@chesterxgchen
Copy link
Collaborator

[✖] https://docs.nvidia.com/bionemo-framework/latest/quickstart-fw.html#docker-container-access → Status: 404

incorrect link

chesterxgchen
chesterxgchen requested changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix link

@YuanTingHsieh
Copy link
Collaborator Author

Holger is updating Bionemo link in his PR we can merge this after that one

@YuanTingHsieh
Copy link
Collaborator Author

/build

@holgerroth
Copy link
Collaborator

@chesterxgchen the links were fixed here #2998

@chesterxgchen chesterxgchen merged commit 5ef2dcb into NVIDIA:2.5 Oct 7, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the update_params_converter_25 branch October 7, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerroth holgerroth holgerroth approved these changes

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @chesterxgchen @holgerroth