Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Cherry pick Update documentation for Dockerfile, add location of tbevents, fix link #3006

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[2.5] Cherry pick Update documentation for Dockerfile, add location of tbevents, fix link #3006

merged 5 commits into from
Oct 8, 2024

Conversation

nvkevlu
Copy link
Collaborator

@nvkevlu nvkevlu commented Oct 7, 2024

Update documentation for Dockerfile, add location of tbevents, fix link.

Description

Cherry pick the updates to documentation for Dockerfile, add location of tbevents, fix link.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvkevlu nvkevlu requested a review from YuanTingHsieh October 7, 2024 21:43
@nvkevlu nvkevlu marked this pull request as draft October 7, 2024 21:44
@nvkevlu nvkevlu marked this pull request as ready for review October 7, 2024 21:49
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Oct 7, 2024

/build

@YuanTingHsieh YuanTingHsieh changed the title Cherry pick Update documentation for Dockerfile, add location of tbevents, fix link [2.5] Cherry pick Update documentation for Dockerfile, add location of tbevents, fix link Oct 7, 2024
YuanTingHsieh
YuanTingHsieh approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need follow up PRs to upgrade the dockerfile to python3.12

@chesterxgchen
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (squash) October 8, 2024 02:25
@IsaacYangSLA IsaacYangSLA merged commit 348ddb1 into NVIDIA:2.5 Oct 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvkevlu @chesterxgchen @YuanTingHsieh @IsaacYangSLA