Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finance end-to-end readme for figure position #3046

Merged

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Correction for figure mis-alignment on finance end-to-end readme

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) October 16, 2024 14:04
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiyueXu77 ZiyueXu77 merged commit 756f0fc into main Oct 16, 2024
38 checks passed
@ZiyueXu77 ZiyueXu77 deleted the Update-Finance-end-to-end-readme-correcting-figure-position branch October 16, 2024 17:48
YuanTingHsieh pushed a commit to YuanTingHsieh/NVFlare that referenced this pull request Dec 10, 2024
@YuanTingHsieh YuanTingHsieh mentioned this pull request Dec 10, 2024
6 tasks
YuanTingHsieh added a commit that referenced this pull request Dec 10, 2024
* Add GNN encoder and xgb outputs for finance end-to-end example (#2970)

* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

---------

Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>

* Update the GNN encoding for XGB financial example (#3039)

* Readme notebook polish and cleanup

* Reorganize folder structure and initial gnn

* Complete the graph generate step with edgemap output

* Format fix

* Format fix

* Add graph construction and training notebooks

* Add full gnn functionality

* Update wording for readme

* update the GNN embedding usage

---------

Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <yuantingh@nvidia.com>

* Add XGB explainability output (#3044)

* Add XGB explainability output

* typo fix

* format fix

* Update finance end-to-end readme for figure position (#3046)

* Update README.md

* Update xgboost.ipynb

* Fix xgb explanability issue (#3078)

* Implement a new algorithm for the CUDA plugin (#3085)

* New cuda plugin implementation

Signed-off-by: YuanTingHsieh <yuantingh@nvidia.com>

* Update docstring

* Rename CellTable to GHPairArray for clarity and allow max_num_of_gh_pair_per_launch to be customized

---------

Signed-off-by: YuanTingHsieh <yuantingh@nvidia.com>

---------

Signed-off-by: YuanTingHsieh <yuantingh@nvidia.com>
Co-authored-by: Ziyue Xu <ziyuex@nvidia.com>
Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants