Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_grad to validation steps #3071

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add no_grad to validation steps #3071

merged 2 commits into from
Nov 25, 2024

Conversation

holgerroth
Copy link
Collaborator

Fixes # .

Description

Add no_grad to validation steps to reduce GPU memory consumption.

Fixes #3067

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth holgerroth added the enhancement New feature or request label Nov 25, 2024
@holgerroth holgerroth enabled auto-merge (squash) November 25, 2024 19:21
@holgerroth
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerroth holgerroth merged commit 0af7099 into NVIDIA:main Nov 25, 2024
20 checks passed
@holgerroth holgerroth deleted the no_grad_splitnn_validation branch November 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add torch.no_grad() to validation examples
2 participants
@holgerroth @YuanTingHsieh