Skip to content

Commit

Permalink
Use top_p=0.0 by default (instead of 1.0)
Browse files Browse the repository at this point in the history
This is because we otherwise do useless computations, at least until
        NVIDIA/NeMo#8905
is merged
  • Loading branch information
odelalleau committed Apr 12, 2024
1 parent 9db62d6 commit c66fba2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion examples/nlp/gpt/conf/gpt_ppo_actor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ model:
use_greedy: False
temperature: 1.0
top_k: 0
top_p: 1.0
top_p: 0.0
repetition_penalty: 1.0
add_BOS: False
all_probs: False
Expand Down
2 changes: 1 addition & 1 deletion examples/nlp/gpt/conf/gpt_spin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ model:
use_greedy: False
temperature: 1.0
top_k: 0
top_p: 1.0
top_p: 0.0
repetition_penalty: 1.0
add_BOS: False
all_probs: False
Expand Down

0 comments on commit c66fba2

Please sign in to comment.