Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Added correct python command version #801

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

ravinder-tw
Copy link
Contributor

@ravinder-tw ravinder-tw commented Oct 14, 2024

Added correct python command version

Description

Added correct python command version. Latest version of python works with python3 instead on python

Relates Issues

NA

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

 Added correct python command version

Signed-off-by: Ravinder Mahajan <88770719+ravinder-tw@users.noreply.github.com>
@ravinder-tw ravinder-tw changed the title Chore: Added correct python command version Doc: Added correct python command version Oct 14, 2024
Signed-off-by: Ravinder Mahajan <88770719+ravinder-tw@users.noreply.github.com>
Signed-off-by: Ravinder Mahajan <88770719+ravinder-tw@users.noreply.github.com>
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ravinder-tw, after making these minor changes we are good to merge.

CONTRIBUTING.md Outdated
@@ -21,8 +21,9 @@ To get started quickly, follow the steps below.
1. Ensure you have Python 3.8+ and [Git](https://git-scm.com/) installed on your system. You can check your Python version by running:

```bash
python --version
python --version or python3 --version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to:

python --version
# or
python3 --version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done!

CONTRIBUTING.md Outdated
```
If not present, please download latest python version from https://www.python.org/downloads/ and try above command
Copy link
Collaborator

@Pouyanpi Pouyanpi Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop this because the user might prefer to use different channel to install Python and we suppose they already know how to do it as they want to contribute. What do you think?

Copy link
Contributor Author

@ravinder-tw ravinder-tw Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, let folks decide how do they wish to install.

I have made required changes. Please review and merge @Pouyanpi

Signed-off-by: Ravinder Mahajan <88770719+ravinder-tw@users.noreply.github.com>
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! Looks good 👍🏻

@Pouyanpi Pouyanpi merged commit 3ec4b67 into NVIDIA:develop Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants