Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update action to support output rail #895

Closed
wants to merge 5 commits into from
Closed

Update action to support output rail #895

wants to merge 5 commits into from

Conversation

noamlevy81
Copy link
Contributor

@noamlevy81 noamlevy81 commented Dec 4, 2024 •
edited
Loading

Description

The current implementation of activefence action allows sending only user messages to activefence API.
This PR allows sending LLM output messages to Activefence API as part ofthe output rail.

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@noamlevy81 noamlevy81 mentioned this pull request Dec 4, 2024
Open
1 task
@noamlevy81
Copy link
Contributor Author

Hi @Pouyanpi, look forward to your input here

@Pouyanpi
Copy link
Collaborator

@noamlevy81 would you please set me as the reviewer? If it is not possible for you just let me know, thanks!

@noamlevy81
Copy link
Contributor Author

noamlevy81 commented Jan 13, 2025 •
edited
Loading

@noamlevy81 would you please set me as the reviewer? If it is not possible for you just let me know, thanks!

I don't have permission the that @Pouyanpi

@Pouyanpi Pouyanpi added enhancement New feature or request status: in review labels Jan 13, 2025
@Pouyanpi Pouyanpi added this to the v0.12.0 milestone Jan 13, 2025
@Pouyanpi Pouyanpi self-requested a review January 20, 2025 11:22
Pouyanpi
Pouyanpi approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @noamlevy81, LGTM! 👍🏻

@Pouyanpi
Copy link
Collaborator

@noamlevy81 Merging is blocked, would you please sign all your commits (some are not verified) per contributing guidelines. Thanks!

@noamlevy81
Copy link
Contributor Author

noamlevy81 commented Jan 20, 2025 •
edited
Loading

@noamlevy81 Merging is blocked, would you please sign all your commits (some are not verified) per contributing guidelines. Thanks!

The not verified one is a pull from develop to my feature branch (I should have probably rebase to avoid that).
How should I best resolve that? With "Signed-off-by" comment on the merge commit?

@noamlevy81 noamlevy81 force-pushed the feature/activefence-output-moderation-rail branch from 25474a8 to 3df5385 Compare January 20, 2025 14:40
@noamlevy81
Copy link
Contributor Author

@Pouyanpi created a new PR to fix the signature issue here

@noamlevy81 noamlevy81 closed this Jan 20, 2025
@Pouyanpi Pouyanpi mentioned this pull request Jan 20, 2025
Merged
4 tasks
@Pouyanpi
Copy link
Collaborator

closed in favor of #940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pouyanpi Pouyanpi Pouyanpi approved these changes

Assignees

@noamlevy81 noamlevy81

Labels
enhancement New feature or request status: in review
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@noamlevy81 @Pouyanpi