-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FP8 plugin recipes #10208
Merged
ShriyaPalsamudram
merged 10 commits into
main
from
maanug/precision-plugin-recipes-with-fp8
Sep 19, 2024
Merged
FP8 plugin recipes #10208
ShriyaPalsamudram
merged 10 commits into
main
from
maanug/precision-plugin-recipes-with-fp8
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should wait to merge until after FP8 is verified. |
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
c8c7d48
to
c3b259a
Compare
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Maanu Grover <maanug@nvidia.com>
ShriyaPalsamudram
previously approved these changes
Sep 11, 2024
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
ShriyaPalsamudram
previously approved these changes
Sep 16, 2024
JimmyZhang12
previously approved these changes
Sep 16, 2024
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
c345109
ShriyaPalsamudram
approved these changes
Sep 19, 2024
rachitgarg91
pushed a commit
to rachitgarg91/NeMo
that referenced
this pull request
Sep 26, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
maanug-nv
added a commit
that referenced
this pull request
Oct 2, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
maanug-nv
added a commit
that referenced
this pull request
Oct 8, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
maanug-nv
added a commit
that referenced
this pull request
Oct 8, 2024
* create mixed precision plugin recipes * cleanup * fix annotation * full definition instead of attach * update docstrings * update fp8 * Apply isort and black reformatting * refactor import --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* create mixed precision plugin recipes Signed-off-by: Maanu Grover <maanug@nvidia.com> * cleanup Signed-off-by: Maanu Grover <maanug@nvidia.com> * fix annotation Signed-off-by: Maanu Grover <maanug@nvidia.com> * full definition instead of attach Signed-off-by: Maanu Grover <maanug@nvidia.com> * update docstrings Signed-off-by: Maanu Grover <maanug@nvidia.com> * update fp8 Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> * Apply isort and black reformatting Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> * refactor import Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com> Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com> Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com> Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com> Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information