Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP8 plugin recipes #10208

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Conversation

maanug-nv
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@maanug-nv
Copy link
Collaborator Author

Should wait to merge until after FP8 is verified.

@maanug-nv maanug-nv mentioned this pull request Aug 19, 2024
8 tasks
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
@maanug-nv maanug-nv force-pushed the maanug/precision-plugin-recipes-with-fp8 branch from c8c7d48 to c3b259a Compare August 21, 2024 17:23
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 5, 2024
@maanug-nv maanug-nv marked this pull request as ready for review September 11, 2024 21:28
@maanug-nv maanug-nv removed the stale label Sep 11, 2024
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
JimmyZhang12
JimmyZhang12 previously approved these changes Sep 16, 2024
@JimmyZhang12 JimmyZhang12 dismissed stale reviews from ShriyaPalsamudram and themself via c345109 September 16, 2024 22:33
@ShriyaPalsamudram ShriyaPalsamudram merged commit 3e251a0 into main Sep 19, 2024
150 of 157 checks passed
@ShriyaPalsamudram ShriyaPalsamudram deleted the maanug/precision-plugin-recipes-with-fp8 branch September 19, 2024 14:30
rachitgarg91 pushed a commit to rachitgarg91/NeMo that referenced this pull request Sep 26, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
maanug-nv added a commit that referenced this pull request Oct 2, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
maanug-nv added a commit that referenced this pull request Oct 8, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
maanug-nv added a commit that referenced this pull request Oct 8, 2024
* create mixed precision plugin recipes



* cleanup



* fix annotation



* full definition instead of attach



* update docstrings



* update fp8



* Apply isort and black reformatting



* refactor import



---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* create mixed precision plugin recipes

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* cleanup

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* fix annotation

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* full definition instead of attach

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update docstrings

Signed-off-by: Maanu Grover <maanug@nvidia.com>

* update fp8

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>

* refactor import

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>

---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Co-authored-by: JimmyZhang12 <67203904+JimmyZhang12@users.noreply.github.com>
Co-authored-by: Jimmy Zhang <jiemingz@nvidia.com>
Co-authored-by: JimmyZhang12 <JimmyZhang12@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants