Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix asr finetune #10508

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix asr finetune #10508

merged 2 commits into from
Sep 18, 2024

Conversation

stevehuang52
Copy link
Collaborator

What does this PR do ?

Fix the bug that model.hparams were not updated when changes to model._cfg were made directly (e.g., in model.setup_optimization())

Collection: [asr,core]

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Additional Information

Signed-off-by: stevehuang52 <heh@nvidia.com>
@stevehuang52 stevehuang52 marked this pull request as ready for review September 17, 2024 15:09
@github-actions github-actions bot added core Changes to NeMo Core ASR labels Sep 17, 2024
nithinraok
nithinraok previously approved these changes Sep 17, 2024
Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Signed-off-by: stevehuang52 <heh@nvidia.com>
@stevehuang52 stevehuang52 merged commit bb721f8 into main Sep 18, 2024
151 of 155 checks passed
@stevehuang52 stevehuang52 deleted the fix_asr_finetune branch September 18, 2024 17:45
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* fix asr finetune

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix vad infer

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* fix asr finetune

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix vad infer

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* fix asr finetune

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix vad infer

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* fix asr finetune

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix vad infer

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* fix asr finetune

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix vad infer

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR core Changes to NeMo Core Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants