Sortformer Diarizer 4spk v1 model PR Part 2: Unit-tests for Sortformer Diarizer. #11336
+5,015
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
…to sortformer/pr_01
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
…to sortformer/pr_01
Signed-off-by: taejinp <tango4j@gmail.com>
…to sortformer/pr_01
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
…to sortformer/pr_01
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
…to sortformer/pr_01
Signed-off-by: taejinp <tango4j@gmail.com>
…to sortformer/pr_01
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
tango4j
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: taejinp <tango4j@gmail.com>
Signed-off-by: tango4j <tango4j@users.noreply.github.com>
Signed-off-by: taejinp <tango4j@gmail.com>
…to sortformer/pr_02
|
beep boop 🤖: 🚨 The following files must be fixed before merge! Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
| sortformer_diar_model = sortformer_model.eval() | ||
| confdict = sortformer_diar_model.to_config_dict() | ||
| sampling_rate = confdict['preprocessor']['sample_rate'] | ||
| target_frame_count = int(sample_len // frame_length) |
Check notice
Code scanning / CodeQL
Unused local variable Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This is the second PR that deals with unit tests for
Sortformer Diarizer Model, 4 speaker limit, v1 model.
Previous PR:
This is PR 2nd out of 3.
1st PR: #11336
3rd PR:
Sortformer Paper:
Sortformer Paper Link
Overview:
NeMo/tests/collections/asrtoNeMo/tests/collections/speaker_tasks.Collection: ASR
Changelog
Updated the
test_data.tar.gzfile in https://github.com/NVIDIA/NeMo/releases/tag/v1.0.0rc1NeMo/tests/collections/speaker_tasks/. ├── test_diar_datasets.py (moved, modified) ├── test_diar_label_models.py (moved, modified) ├── test_diar_lhotse_datasets.py (created) ├── test_diar_metrics.py (moved, modified) ├── test_diar_neural_inference.py (moved, modified) ├── test_diar_sortformer_models.py (created) ├── test_speaker_label_models.py (moved) └── utils ├── test_data_simul_utils.py (moved) ├── test_diar_utils.py (moved) ├── test_multispeaker_utils.py (created) └── test_vad_utils.py (moved)Usage
GitHub Actions CI
Added the new CIs for Sortformer Diarizer.
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information