Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeMo-UX: MegatronAutoModel #11341

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Nov 20, 2024

What does this PR do ?

model = AutoModel("meta-llama/Llama-3.1-8B")
print(model)
> LlamaModel()

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_auto_model branch 2 times, most recently from 20e9d6b to 433af57 Compare November 20, 2024 14:39
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
nemo/collections/llm/gpt/model/auto_model.py Fixed Show fixed Hide fixed
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_auto_model branch 2 times, most recently from 346023e to 28e4cc9 Compare November 20, 2024 14:59
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_auto_model branch from 28e4cc9 to 802b260 Compare November 20, 2024 15:00
@akoumpa akoumpa changed the title AutoModel init commit AutoModel Nov 20, 2024
@akoumpa akoumpa changed the title AutoModel NeMo-UX: AutoModel Nov 20, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_auto_model branch from 16482c1 to cf2d570 Compare November 20, 2024 15:08
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_auto_model branch from 000e351 to 3e9b787 Compare November 20, 2024 15:15
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.gpt.model.auto_model
nemo/collections/llm/gpt/model/auto_model.py:49:0: C0115: Missing class docstring (missing-class-docstring)

-----------------------------------
Your code has been rated at 9.72/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

@akoumpa akoumpa changed the title NeMo-UX: AutoModel NeMo-UX: MegatronAutoModel Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant