Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SquadDataModule to use run.config #11358

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huvunvidia
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.recipes.t5_220m
nemo/collections/llm/recipes/t5_220m.py:232:0: C0301: Line too long (121/119) (line-too-long)
************* Module nemo.collections.llm.t5.data.squad
nemo/collections/llm/t5/data/squad.py:33:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/llm/t5/data/squad.py:34:0: C0301: Line too long (123/119) (line-too-long)
nemo/collections/llm/t5/data/squad.py:38:0: C0301: Line too long (129/119) (line-too-long)
nemo/collections/llm/t5/data/squad.py:39:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/llm/t5/data/squad.py:103:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/llm/t5/data/squad.py:78:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/t5/data/squad.py:154:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.18/10

Thank you for improving NeMo's documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant