Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starcoder2 missing bias in nemo2 config for TRTLLM #11809

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix starcoder2 missing bias in nemo2 config for TRTLLM #11809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60b322
Fix starcoder2 missing bias in nemo2 config
meatybobby Jan 9, 2025
f713747
Merge branch 'main' into bobchen/sc2_bias
oyilmaz-nvidia Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nemo/export/trt_llm/nemo_ckpt_loader/nemo_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,9 @@ def load_nemo_model(nemo_ckpt: Union[str, Path], nemo_export_dir: Union[str, Pat
elif nemo_model_config["activation"] == "squared_relu":
nemo_model_config["activation"] = "squared-relu"

if nemo_model_config.get("add_bias_linear"):
nemo_model_config["bias"] = True

nemo_model_config["mcore_gpt"] = True
nemo_model_config["max_position_embeddings"] = nemo_model_config.get("seq_length", 4096)
nemo_model_config["rotary_percentage"] = nemo_model_config.get("rotary_percent", 1.0)
Expand Down
Loading