[WIP] add buffered chunked streaming for nemo force aligner #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erastorgueva-nv
requested changes
Mar 29, 2023
|
cc @jbalam-nv for visibility on changes to streaming_utils. I don't think they will break anything. |
erastorgueva-nv
previously approved these changes
Mar 30, 2023
github-actions
bot
added
CI
common
core
added 2 commits
April 3, 2023 13:02
Signed-off-by: Slyne Deng <slyned@nvidia.com>
Signed-off-by: Slyne Deng <slyned@nvidia.com>
erastorgueva-nv
approved these changes
Apr 4, 2023
titu1994
reviewed
Apr 4, 2023
| frame_buffers = self.frame_bufferer.get_buffers_batch() | ||
|
|
||
| while len(frame_buffers) > 0: | ||
| self.frame_buffers += frame_buffers[:] | ||
| self.data_layer.set_signal(frame_buffers[:]) | ||
| self._get_batch_preds() | ||
| self._get_batch_preds(keep_logits) |
There was a problem hiding this comment.
Is it possible to avoid changing signatures of these functions ? Ie set a bool value from config or some other way (class arg or setter function) and rest of the functions just use that ?
| return hypothesis | ||
|
|
||
| all_logits = [] | ||
| for log_prob in self.all_logits: |
There was a problem hiding this comment.
Could you put this in a function? I feel like it gets repeated a lot
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
) * add nfa buffered streaming Signed-off-by: Slyne Deng <slyned@nvidia.com> * restore to previous __iter__ function Signed-off-by: Slyne Deng <slyned@nvidia.com> --------- Signed-off-by: Slyne Deng <slyned@nvidia.com> Co-authored-by: Slyne Deng <slyned@nvidia.com> Co-authored-by: Elena Rastorgueva <80532067+erastorgueva-nv@users.noreply.github.com> Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
To support buffered chunked streaming inference for nemo neural force aligner.
Collection: [Note which collection this PR will affect]
ASR
Changelog
FrameBatchASRto keep the inference logits.Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information