Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore path for p-tuning #6273

Merged
merged 7 commits into from
Apr 4, 2023
Merged

restore path for p-tuning #6273

merged 7 commits into from
Apr 4, 2023

Conversation

arendu
Copy link
Collaborator

@arendu arendu commented Mar 22, 2023

What does this PR do ?

Pr allows you to pretrain a prompt-encoder.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
@github-actions github-actions bot added the NLP label Mar 22, 2023
@arendu arendu changed the title Continue to p-tune from a seed model restore path for p-tuning Mar 22, 2023
@arendu arendu marked this pull request as ready for review March 30, 2023 23:01
Copy link
Collaborator

@Zhilin123 Zhilin123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one thing that makes it clearer is to explain how one would use this continued training feature (maybe should someone just copy a pretrained ptuning.nemo into the working directory of the new training)?

@arendu arendu merged commit eb633a2 into main Apr 4, 2023
@arendu arendu deleted the adithyare/continue_p_tune branch April 4, 2023 21:51
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
* bug fix to seed prompt encoder with nemo model

Signed-off-by: arendu <adithya.r@gmail.com>

* update for continued training

Signed-off-by: arendu <adithya.r@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: arendu <adithya.r@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants