Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated lr for FC configs #6379

Merged
merged 1 commit into from
Apr 6, 2023
Merged

updated lr for FC configs #6379

merged 1 commit into from
Apr 6, 2023

Conversation

bmwshop
Copy link
Collaborator

@bmwshop bmwshop commented Apr 5, 2023

What does this PR do ?

Refines the suggested training parameters for the Fast Conformer models.

Collection: ASR

Changelog

  • In fast-conformer_ctc_bpe.yaml, change min_lr to 1e-4 (from 1e-6)
  • in fast-conformer_transducer_bpe.yaml, change lr to 5e-3 and min_lr to 5e-4 (from 1e-6)

Usage

  • Train as usual but you will be able to use checkpoint averaging to improve results
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Dima Rekesh <bmwshop@gmail.com>
@github-actions github-actions bot added the ASR label Apr 5, 2023
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Collaborator

@VahidooX VahidooX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we reduce max epochs to something more affordable, like 500 epochs, so that the learning curve matches what we expect?

@bmwshop bmwshop merged commit cff6324 into main Apr 6, 2023
@bmwshop bmwshop deleted the fcconfigmods branch April 6, 2023 01:01
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Dima Rekesh <bmwshop@gmail.com>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants