Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed torch warning on using a list of numpy arrays #6382

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

MKNachesa
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: ASR

Changelog

  • Fixed torch warning about creating a tensor from a list of numpy arrays and sped up execution by putting audio in a list when calling np.array() instead of when calling torch.tensor()

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Signed-off-by: MKNachesa <maya.nachesa@gmail.com>
@nithinraok nithinraok merged commit d2add6f into NVIDIA:main Apr 7, 2023
limdongjin pushed a commit to limdongjin/NeMo that referenced this pull request Apr 10, 2023
Signed-off-by: MKNachesa <maya.nachesa@gmail.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: MKNachesa <maya.nachesa@gmail.com>
Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants