[TTS] relax hardcoded prefix for phonemes and tones and infer phoneme set through dict #6735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
previously, '#' was hardcoded as a prefix for Chinese phonemes and tones in both g2p and tokenizer. It is apt to raise errors if mismatched prefix symbols are applied for g2p and tokenizer.
previously, phoneme set and tone set are hardcoded as well. It would raise errors when the input phoneme dict contains different set of phonemes. Fixed this by inferring phoneme set based on input dictionary.
run pytest nightly and old NGC model checkpoint passed.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information