Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text_generation_utils memory reduction if no logprob needed #6773
text_generation_utils memory reduction if no logprob needed #6773
Changes from 22 commits
6d3aa7c
1b077de
30cd1e2
94ff7a7
fcb8379
2b1e2b5
2b31551
a7f3c66
abe634c
4529e52
269b59d
11dccff
bb6937e
342beb0
0d46e07
d4c5703
6689ade
5957cc3
a87891f
4c93fc4
7292468
c43106c
34fbabc
ea9c983
213218c
c50bce7
d1287bc
aacb2d3
b9c285a
9d914c8
5c9f87b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone want's to truncate their prompt, like with p-tuning truncating the context. but this is not a deal breaker, so your call if you want to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i can revert the bs