-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update container for import action #6883
Conversation
Signed-off-by: ericharper <complex451@gmail.com>
I think triton needs to be removed from pip. It's causing forced update to pytorch 2, which then breaks multiple dependencies. I think it was already removed from main though |
Signed-off-by: ericharper <complex451@gmail.com>
Not sure how that ended up on our requirements :/ |
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to separate out the test !
What does this PR do ?
Updates the base container for import action. Testing if this helps the NLP import test which is currently timing out due to solver issues with pip.
Edit: The issue was with installing and uninstalling nemo for each of the domains. This was wreaking havoc on the solver so we instead test each domain in parallel from a clean environment.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information