Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container for import action #6883

Merged
merged 13 commits into from
Jun 20, 2023
Merged

Update container for import action #6883

merged 13 commits into from
Jun 20, 2023

Conversation

ericharper
Copy link
Collaborator

@ericharper ericharper commented Jun 18, 2023

What does this PR do ?

Updates the base container for import action. Testing if this helps the NLP import test which is currently timing out due to solver issues with pip.

Edit: The issue was with installing and uninstalling nemo for each of the domains. This was wreaking havoc on the solver so we instead test each domain in parallel from a clean environment.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: ericharper <complex451@gmail.com>
@github-actions github-actions bot added the CI label Jun 18, 2023
@titu1994
Copy link
Collaborator

I think triton needs to be removed from pip. It's causing forced update to pytorch 2, which then breaks multiple dependencies. I think it was already removed from main though

Signed-off-by: ericharper <complex451@gmail.com>
@ericharper
Copy link
Collaborator Author

I think triton needs to be removed from pip. It's causing forced update to pytorch 2, which then breaks multiple dependencies. I think it was already removed from main though

Not sure how that ended up on our requirements :/

Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
Signed-off-by: ericharper <complex451@gmail.com>
@ericharper ericharper marked this pull request as ready for review June 19, 2023 00:01
@ericharper ericharper requested a review from titu1994 June 19, 2023 00:01
@ericharper ericharper marked this pull request as draft June 19, 2023 00:03
@ericharper ericharper marked this pull request as ready for review June 19, 2023 00:05
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to separate out the test !

@titu1994 titu1994 merged commit 63d9b2c into main Jun 20, 2023
@titu1994 titu1994 deleted the update_import_action branch June 20, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants