Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Frame-VAD doc #6902

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Update Frame-VAD doc #6902

merged 4 commits into from
Jun 22, 2023

Conversation

stevehuang52
Copy link
Collaborator

What does this PR do ?

Update doc for Frame-VAD

Collection: [ASR]

Signed-off-by: stevehuang52 <heh@nvidia.com>
@stevehuang52 stevehuang52 requested a review from fayejf June 21, 2023 20:22
@github-actions github-actions bot added the ASR label Jun 21, 2023
fayejf
fayejf previously approved these changes Jun 22, 2023
Copy link
Collaborator

@fayejf fayejf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Some small comments

examples/asr/speech_classification/README.md Outdated Show resolved Hide resolved
examples/asr/speech_classification/README.md Show resolved Hide resolved
Copy link
Collaborator

@fayejf fayejf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@fayejf fayejf merged commit 4726650 into main Jun 22, 2023
@fayejf fayejf deleted the add_fvad_doc branch June 22, 2023 23:06
sudhakarsingh27 pushed a commit that referenced this pull request Jun 27, 2023
* update fvad doc

Signed-off-by: stevehuang52 <heh@nvidia.com>

* fix typo

Signed-off-by: stevehuang52 <heh@nvidia.com>

---------

Signed-off-by: stevehuang52 <heh@nvidia.com>
Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
Signed-off-by: Sudhakar Singh <sudhakars@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants