New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gpt trainer test #6915

Merged

hsiehjackson merged 156 commits into main from fix-gpt-trainer-test

Aug 10, 2023

Collaborator

hsiehjackson commented Jun 24, 2023 •

edited

Loading

What does this PR do ?

Fix gpt trainer inference_step to compute generation results during validation and test
Add dataset with metadata, to output in prediction file
Add token_f1 metrics for Scrolls

Collection: [NLP]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

hsiehjackson added 2 commits

June 23, 2023 18:23


          Add trainer.test() for GPT

5f0d53b

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>


          Remove unused part

e6865c8

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

hsiehjackson requested review from yzhang123 and MaximumEntropy

June 24, 2023 01:34

github-actions bot added the NLP label

hsiehjackson force-pushed the fix-gpt-trainer-test branch 2 times, most recently from 70e3747 to fadf272 Compare

June 26, 2023 16:47

yzhang123 reviewed

View reviewed changes

nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py Show resolved Hide resolved

yzhang123 reviewed

View reviewed changes

examples/nlp/language_modeling/tuning/megatron_gpt_peft_eval.py Show resolved Hide resolved

hsiehjackson and others added 3 commits

June 27, 2023 06:06


          Add trainer.test() for GPT

de3cc19

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>


          Remove unused part

87ce549

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>


          [pre-commit.ci] auto fixes from pre-commit.com hooks

74c6fd8

for more information, see https://pre-commit.ci

hsiehjackson force-pushed the fix-gpt-trainer-test branch from fadf272 to 74c6fd8 Compare

June 26, 2023 22:06

hsiehjackson added 2 commits

June 27, 2023 12:23


          Fix training part

98da36e

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>


          Fix conflict

9656fa9

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

github-actions bot added the CI label

pre-commit-ci bot and others added 5 commits

June 27, 2023 19:28


          [pre-commit.ci] auto fixes from pre-commit.com hooks

7c240b3

for more information, see https://pre-commit.ci


          Fix config

c22cfd6

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>


          Merge branch 'fix-gpt-trainer-test' of https://github.com/NVIDIA/NeMo …

83ff763

…into fix-gpt-trainer-test


          Merge branch 'main' into fix-gpt-trainer-test

afa9030


          Merge branch 'main' into fix-gpt-trainer-test

ae0f1f0

arendu self-requested a review

June 27, 2023 23:36

arendu reviewed

View reviewed changes

examples/nlp/language_modeling/tuning/megatron_gpt_peft_eval.py Outdated Show resolved Hide resolved

arendu reviewed

View reviewed changes

nemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py Outdated Show resolved Hide resolved

arendu reviewed

View reviewed changes

nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py Show resolved Hide resolved

arendu reviewed

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

hsiehjackson and others added 4 commits

June 27, 2023 20:13


          Fix references and add CI

a4588f4

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>


          Merge branch 'fix-gpt-trainer-test' of https://github.com/NVIDIA/NeMo …

689f96c

…into fix-gpt-trainer-test


          [pre-commit.ci] auto fixes from pre-commit.com hooks

6d7c857

for more information, see https://pre-commit.ci


          Fix config error

3bbc4e7

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

arendu reviewed

View reviewed changes

nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py Show resolved Hide resolved

hsiehjackson and others added 6 commits

August 4, 2023 15:53


          skip generation with metric loss

4c712ae

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>


          Merge branch 'fix-gpt-trainer-test' of https://github.com/NVIDIA/NeMo …

b99f522

…into fix-gpt-trainer-test


          [pre-commit.ci] auto fixes from pre-commit.com hooks

2b59de8

for more information, see https://pre-commit.ci


          Revert

ee74e54

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>


          Fix conflict

9b9626b

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>


          [pre-commit.ci] auto fixes from pre-commit.com hooks

67ec1b2

for more information, see https://pre-commit.ci

hsiehjackson requested a review from arendu

August 5, 2023 00:55

hsiehjackson and others added 4 commits

August 7, 2023 10:37


          Merge branch 'main' into fix-gpt-trainer-test

82a940c

Signed-off-by: Cheng-Ping Hsieh <37269846+hsiehjackson@users.noreply.github.com>


          Merge branch 'main' into fix-gpt-trainer-test

c51754e


          [pre-commit.ci] auto fixes from pre-commit.com hooks

ac1241f

for more information, see https://pre-commit.ci


          Fix bug

29f775c

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

ekmb previously approved these changes

View reviewed changes

arendu previously approved these changes

View reviewed changes

Kipok reviewed

View reviewed changes

nemo/collections/nlp/data/language_modeling/megatron/gpt_sft_dataset.py Show resolved Hide resolved

yzhang123 previously approved these changes

View reviewed changes


          support GPTSFTChatDataset

cf2f2b9

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

hsiehjackson dismissed stale reviews from yzhang123, arendu, and ekmb via

cf2f2b9

August 10, 2023 02:48


          [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

yidong72 reviewed

View reviewed changes

Collaborator

yidong72 left a comment

Looks good overall, please don't change the default configuration behavior as the old code depends on it.

examples/nlp/language_modeling/tuning/conf/megatron_gpt_sft.yaml Show resolved Hide resolved

examples/nlp/language_modeling/tuning/conf/megatron_gpt_sft.yaml Show resolved Hide resolved

examples/nlp/language_modeling/tuning/conf/megatron_gpt_sft.yaml

-                    drop_last: True
-                    context_key: 'input'
-                    label_key: 'output'
+                    drop_last: False

Collaborator

yidong72 Aug 9, 2023

don't change the default behavior

Collaborator Author

hsiehjackson Aug 10, 2023

Why we drop last if we evaluate with the validation dataset?

Collaborator

yidong72 Aug 10, 2023

I have one use case that I have to drop the last because I am preparing a dataset that computes contrastive loss. I need to make sure all the batch has the same batch size.

Collaborator Author

hsiehjackson Aug 10, 2023

If we set drop_last=False, we can use pad_samples_to_global_batch_size=True right? Or this doesn't fulfill your settings? https://github.com/NVIDIA/NeMo/blob/fix-gpt-trainer-test/nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py#L788
If we set default drop_last=True, then we may drop some samples for evaluation which may show incorrect results for comparison.

nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py Show resolved Hide resolved

hsiehjackson added 2 commits

August 9, 2023 20:14


          Add comment

9f936c0

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>


          Merge branch 'fix-gpt-trainer-test' of https://github.com/NVIDIA/NeMo …

3d3fccc

…into fix-gpt-trainer-test

ekmb approved these changes

View reviewed changes

hsiehjackson merged commit e0f8b9b into main

hsiehjackson deleted the fix-gpt-trainer-test branch

August 10, 2023 19:44

dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request


          Fix gpt trainer test (NVIDIA#6915)

e924591

* Add trainer.test() for GPT

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Remove unused part

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Add trainer.test() for GPT

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Remove unused part

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix training part

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix references and add CI

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config error

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix dataset

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add metadata

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix empty batch

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix max seq length

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix dataset

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix dataset

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add token f1

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add FA in sft

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add inference config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix pad

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix num batch

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Add query_key

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove pdb

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix write json

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix dataset bug and refactor

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add logging for prediction

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix retrain

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Add query_key in config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add inference config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix mask

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix mask

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Split PR

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Undo commit

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Add query_key to doc_string

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Adjust yzhang123 comments

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix error and follow comments

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove query key

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Remove logic and query

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove query from model

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Remove query_key

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Fix error

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix pdb

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Add default tokens_to_generate

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Revert prompt truncate re-prompt

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* skip generation with metric loss

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix bug

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* support GPTSFTChatDataset

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add comment

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

---------

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Signed-off-by: Cheng-Ping Hsieh <37269846+hsiehjackson@users.noreply.github.com>
Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: dorotat <dorotat@nvidia.com>

stevehuanghe mentioned this pull request

placeholder from Speechllm selene to main zhehuaichen/NeMo#13

Closed

8 tasks

rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request


          Fix gpt trainer test (NVIDIA#6915)

1d9856f

* Add trainer.test() for GPT

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Remove unused part

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Add trainer.test() for GPT

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Remove unused part

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix training part

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix references and add CI

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config error

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix dataset

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add metadata

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix empty batch

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix max seq length

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix dataset

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix dataset

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add token f1

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add FA in sft

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add inference config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix pad

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix num batch

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Add query_key

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove pdb

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix write json

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix dataset bug and refactor

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add logging for prediction

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix retrain

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Add query_key in config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add inference config

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix bug

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix mask

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix mask

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>

* Split PR

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Undo commit

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Add query_key to doc_string

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Adjust yzhang123 comments

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix error and follow comments

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove query key

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Remove logic and query

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove query from model

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Remove query_key

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Fix error

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix pdb

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Add default tokens_to_generate

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Revert prompt truncate re-prompt

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* skip generation with metric loss

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix bug

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* support GPTSFTChatDataset

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add comment

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

---------

Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Signed-off-by: Cheng-Ping Hsieh <37269846+hsiehjackson@users.noreply.github.com>
Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yidong72 yidong72 left review comments

Kipok Kipok left review comments

ekmb ekmb approved these changes

arendu arendu left review comments

yzhang123 yzhang123 left review comments

MaximumEntropy Awaiting requested review from MaximumEntropy

aklife97 Awaiting requested review from aklife97

ericharper Awaiting requested review from ericharper

Labels